Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

entry_to_string function implemented #465

Open
wants to merge 5 commits into
base: latest
Choose a base branch
from

Conversation

KlowdfurrRad
Copy link

@KlowdfurrRad KlowdfurrRad commented Oct 9, 2024

Implemented entry_to_string function.
Wrote 3-4 simple tests for it.
Wrote documentation for entry_to_string in /include/stumpless/entry.h

Let me know what changes I should make.

#448

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 85.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 90.51%. Comparing base (1d2df58) to head (34783a7).

Files with missing lines Patch % Lines
src/entry.c 85.00% 7 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           latest     #465      +/-   ##
==========================================
- Coverage   90.59%   90.51%   -0.08%     
==========================================
  Files          47       47              
  Lines        4379     4439      +60     
  Branches      587      594       +7     
==========================================
+ Hits         3967     4018      +51     
- Misses        279      286       +7     
- Partials      133      135       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@goatshriek
Copy link
Owner

Checking in to see if you plan to continue work on this, per the project's inactivity policy. Resolving the CI failures is a good next step.

@KlowdfurrRad
Copy link
Author

Checking in to see if you plan to continue work on this, per the project's inactivity policy. Resolving the CI failures is a good next step.

Hey, sorry.
Do you have any idea where I can start to resolve the CI failures ? I am not very familiar with CI.

@goatshriek
Copy link
Owner

The CI runs (GitHub Actions in this case) are essentially just scripts that are run to run tests, examples, and perform other checks on the code. You can look into the .github/workflows folder for their definitions.

It's been long enough that the logs from the failed runs have aged off. I recommend you run the tests locally on your own machine to see what is failing, and then fix that. You can look at the test documentation for instructions on building and running the tests, or just copy what the GitHub Action does.

@KlowdfurrRad
Copy link
Author

The CI runs (GitHub Actions in this case) are essentially just scripts that are run to run tests, examples, and perform other checks on the code. You can look into the .github/workflows folder for their definitions.

It's been long enough that the logs from the failed runs have aged off. I recommend you run the tests locally on your own machine to see what is failing, and then fix that. You can look at the test documentation for instructions on building and running the tests, or just copy what the GitHub Action does.

Thank you ! I will take a look at this again soon , I hope :/. My semester is packed but I do want to try working on code like this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants