Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(NOBIDS) temporarily disable ens-errors until BIdS-2437 is solved #2823

Closed
wants to merge 2 commits into from
Closed

(NOBIDS) temporarily disable ens-errors until BIdS-2437 is solved #2823

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d47b8f0
(NOBIDS) temporarily disable ens-errors until BIdS-2437 is solved
guybrush Jan 19, 2024
d7bef26
(NOBIDS) fix error message
guybrush Jan 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion db/ens.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -526,7 +526,10 @@ func validateEnsName(client *ethclient.Client, name string, alreadyChecked *EnsC
}
return nil
}
return fmt.Errorf("error could not resolve name [%v]: %w", name, err)
// temporarily disabled, see BIDS-2437 #TODO:patrick
// return fmt.Errorf("error could not resolve name [%v]: %w", name, err)
logger.Errorf("error could not resolve name [%v]: %v", name, err)
return nil
}

// we need to get the main domain to get the expiration date
Expand Down