(BIDS-2981) fix activation estimation for eip-7514 #2828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elenore23
approved these changes
Jan 30, 2024
D13ce
suggested changes
Jan 31, 2024
There was a problem hiding this comment.
The build for this PR fails. You have added a new function getValidatorActivationChurnLimit that is not used anywhere. Removing it would solve the build error but it would also render the whole PR almost meaningless as it is the only location where the new config value MaxPerEpochActivationChurnLimit is used.
services/stats.go
Outdated
| @@ -199,6 +199,21 @@ func eth1UniqueValidatorsCount() (*uint64, error) { | |||
| } | |||
|
|
|||
| // GetValidatorChurnLimit returns the rate at which validators can enter or leave the system | |||
There was a problem hiding this comment.
This tool tip contains the wrong function name (GetValidatorChurnLimit).
Also, is it correct? Based on the function name I would assume that this is only about the enter rate and not about the leave rate.
guybrush
force-pushed
the
BIDS-2981/fix-activation-estimation
branch
from
4b93d73 to
1e7a987
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.