Conversation
enzo-bitfly
force-pushed
the
FE-149/api-promotion-banner
branch
from
b2ab65d to
5d71b21
Compare
peterbitfly
requested changes
Oct 21, 2025
Collaborator
peterbitfly
left a comment
peterbitfly
left a comment
There was a problem hiding this comment.
generally LGTM, needs some refinement on the promo phrases and links before we can merge it. also do we still need the hero.html file?
enzo-bitfly
force-pushed
the
FE-149/api-promotion-banner
branch
from
5d71b21 to
199f978
Compare
remove unused `hero` template See: FE-149
enzo-bitfly
force-pushed
the
FE-149/api-promotion-banner
branch
from
199f978 to
704628c
Compare
Collaborator
Author
|
@peterbitfly texts and links are adapted, and |
peterbitfly
approved these changes
Oct 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
encapsulate unused
herostylesSee: FE-149