Fix Variant -> Gd conversions not taking into account dead objects
#1033
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yarwin
reviewed
Feb 2, 2025
| /// Does not check again that the variant has type `OBJECT`. | ||
| pub(crate) fn is_object_dead(&self) -> bool { | ||
| // There is no dedicated API, however the string repr has a special value for dead objects. | ||
| self.stringify() == "<Freed Object>".into() |
There was a problem hiding this comment.
what about is_instance_valid?
Note: It is deprecated for public use, but reserving it for internal use (pub(crate) won't allow to use it even in itest) seems to be better idea than relying on repr for nullptr checks 😅
There was a problem hiding this comment.
Oh, great idea! Totally forgot that that one takes variant as arguments 😅 who knew that would come in handy one day...
Bromeon
force-pushed
the
bugfix/variant-dead-objects
branch
2 times, most recently
from
6e7043c to
25552db
Compare
Bromeon
force-pushed
the
bugfix/variant-dead-objects
branch
from
25552db to
981f29a
Compare
(Still non-public API for now)
Bromeon
force-pushed
the
bugfix/variant-dead-objects
branch
from
f1ec846 to
6f5383e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Variant::to(),Variant::try_to()andGd::from_variant()did not recognize when the object living inside the variant was dead. This sometimes caused a panic"constructed RawGd weak pointer with instance ID 0", but generally caused UB, since the object pointer inside the variant was already dangling at that point.Also improves error messages when converting variants of other types to object.
Old:
new:
Furthermore, this fixes
Debugimpl hitting infinite recursion upon encountering a dead object.Now prints
<Freed Object>instead.