feat(QoL): Renames some functions to a more stadard rust naming - #1673
Closed
naomijub wants to merge 1 commit into
Closed
feat(QoL): Renames some functions to a more stadard rust naming#1673naomijub wants to merge 1 commit into
naomijub wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per #1672
What
Renames a set of accessor/constructor methods across gdext to follow standard
Rust naming conventions for fallibility:
get_*: returnsOption<T>when the operation is a genuine lookup thatmay not find anything (mirrors an existing Godot
get_*_or_null-style method).checked_*: returnsOption<T>when the operation is a construction orconversion that validates before returning (not a lookup).
try_*: reserved for methods returningResult<T, E>, distinguishing whyan operation failed.
Changes
Node::get_node_as/Node::try_node_asPackedScene::instantiate_as/try_instantiate_asWhy
Rust conventions establish
getas Option-returning (HashMap::get,slice::get) andtry_as Result-returning (TryFrom, etc.), the previousnaming had this inverted, which is surprising for anyone coming from std.