Fix (no base) showing up in all the docs

[lilizoey]

We were setting class_name to be (no base) in the PropertyInfo for all types by default. However that makes godot show the class_name in return values and arguments.

I dont know if there's a good way to test this? It would involve us checking what documentation is generated by godot which doesn't seem like something we can easily do.

closes #159

[lilizoey]

bors try

[Bromeon]

Thanks! 🙂

I don't think we need both a default value and Option -- there should be only one way to represent the "absent" state. Since Godot interprets the empty string as "there is no class name" (correct me if I'm wrong), the default value is more natural, and we don't need Option at all.

[Bromeon]

Maybe add a line that says that the default value (empty string) represents no class name.

Alternatively, there could be an explicit function ClassName::none().

[bors]

try

Build succeeded:

• full-ci

[Bromeon]

About the test, a random idea would be to check Godot's reflection APIs, such as Object.get_method_list().

The args is only documented to be an array of dictionaries; its keys are not specified. So the doc string might or might not be part of it -- I guess we need to try.

Otherwise, it's also totally fine if we don't test everything programmatically 🙂

[lilizoey]

About the test, a random idea would be to check Godot's reflection APIs, such as Object.get_method_list().

The args is only documented to be an array of dictionaries; its keys are not specified. So the doc string might or might not be part of it -- I guess we need to try.

Otherwise, it's also totally fine if we don't test everything programmatically slightly_smiling_face

I dont think it'll help much, as we want to make sure that the method info we output is rendered properly. but args is just an array of dictionaries that will mirror the info back at us (also the dictionary's keys are documented to match https://docs.godotengine.org/en/stable/classes/class_object.html#class-object-method-get-property-list), but wont give us info about how the documentation page renders it.

[Bromeon]

True; I was actually looking for a method that would return something like a doc string, but couldn't find any.

The method list was the 2nd best option, but you're right that it might just give us what we enter. This would still test that within gdext, we end up passing the right value for class names, but this is not really giving us anything at the current complexity.

[Bromeon]

Sorry, I meant "alternatively" as in "not providing default".

This avoids accidental implicit construction (we also don't need 2 methods doing the same thing here).

Suggested change

	/// In Godot, an empty `StringName` in a place that expects a class name, means that there is no class.
	pub fn none() -> Self {
	Self::default()
	}
	/// In Godot, an empty `StringName` in a place that expects a class name, means that there is no class.
	pub fn none() -> Self {
	Self {
	backing: StringName::default(),
	}
	}

[Bromeon]

Thanks a lot!

bors r+

[bors]

Build succeeded:

• full-ci