Skip to content

Reflect the changes to Rider setup after the fix of the project generation logic to support any OS with and without MSVC toolchain #10754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 14, 2025
Merged

Reflect the changes to Rider setup after the fix of the project generation logic to support any OS with and without MSVC toolchain #10754

merged 2 commits into from
Apr 14, 2025

Conversation

van800
Copy link
Contributor

@van800 van800 commented Mar 8, 2025

I propose to land this after godotengine/godot#103405

@van800 van800 force-pushed the shakhov/macosx branch 5 times, most recently from b41ebc9 to a6f0f62 Compare March 9, 2025 12:14
@van800 van800 changed the title Reflect the changes to Rider setup after the fix of the project generation logic to support any OS without MSVC toolchain Reflect the changes to Rider setup after the fix of the project generation logic to support any OS with and without MSVC toolchain Mar 9, 2025
@skyace65 skyace65 added enhancement area:contributing Issues and PRs related to the Contributing/Development section of the documentation waiting on PR merge PR's that can't be merged until an engine PR is merged first labels Mar 9, 2025
@van800 van800 mentioned this pull request Mar 10, 2025
Merged
@van800 van800 force-pushed the shakhov/macosx branch 3 times, most recently from 8265b50 to d69af8a Compare April 3, 2025 11:33
@van800
Reflect the changes to Rider setup after the fix of the project gener…
566e24e 
…ation logic to support any OS without MSVC toolchain
@skyace65 skyace65 added this to the 4.5 milestone Apr 11, 2025
@skyace65 skyace65 removed the waiting on PR merge PR's that can't be merged until an engine PR is merged first label Apr 11, 2025
skyace65
skyace65 requested changes Apr 11, 2025
View reviewed changes
Copy link
Contributor

@skyace65 skyace65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just going to make one minor formatting change

@skyace65
Copy link
Contributor

Thanks! I'll get this merged once we start merging 4.5 only PRs.

@mhilbrunner mhilbrunner merged commit 309c3c0 into godotengine:master Apr 14, 2025
1 check passed
@mhilbrunner
Copy link
Member

4.5 docs are starting, merged. Thanks for contributing! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhilbrunner mhilbrunner mhilbrunner approved these changes

@skyace65 skyace65 skyace65 approved these changes

Assignees
No one assigned
Labels
area:contributing Issues and PRs related to the Contributing/Development section of the documentation enhancement
Projects
None yet
Milestone
4.5
Development

Successfully merging this pull request may close these issues.
3 participants
@van800 @skyace65 @mhilbrunner