Use std::size instead of sizeof(a) / sizeof(a[0]) pattern throughout the codebase.
#102419
+71
−67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…out the codebase.
|
FYI I got the compiler error fixed, but I'm waiting to rebase on top of #102396 when it's merged, to modify the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identified this in a discussion.
In short,
std::sizeis the canonical way to determine the number of elements in a C-style array starting from C++17. Using it looks slightly cleaner than thesizeof(a) / sizeof(a[0])pattern, and is less error prone to regressions.I took the opportunity to add
constexprto a few of the affected variables (where possible).The change does have one downside, which is that
#include <array>must be added in two spots. This is unlikely to observably affect compile times.