Don't expose AnimationNodeStartState and AnimationNodeEndState as internal, this triggers a ClassDB bug #102433
+2
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
commented
Feb 4, 2025
Comment on lines
1325
to
1326
| return !(states[p_name].node->is_class("AnimationNodeStartState") || states[p_name].node->is_class("AnimationNodeEndState")); | ||
| const Ref<AnimationNode> &anode = states[p_name].node; | ||
| return !(Ref<AnimationNodeStartState>(anode).is_valid() || Ref<AnimationNodeEndState>(anode).is_valid()); |
There was a problem hiding this comment.
Note that I didn't actually check whether this needed to change to work. But in general relying on casting pointers seems better than a string check through ClassDB.
…ernal, this triggers a ClassDB bug Fixes godotengine#99534.
akien-mga
force-pushed
the
unexpose-AnimationNodeStartState-EndState
branch
from
4a30bf0 to
ede3d21
Compare
|
@TokageItLab Can you take a look? |
TokageItLab
approved these changes
Feb 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #99534.
Please test to confirm the functionality still works, I don't know how to use of it.