Skip to content

Conversation

ghost
Copy link

@ghost ghost commented Sep 13, 2018

@strangepowers @priom @ChainSafe @noot

Needed for go-ethereum PR 😄

Changelog

  • Gofmt for go linter test
  • Changed default goreli genesis block to match with Parity ( Still WIP, need fix on Aura engine )
  • Removed build-related files
    + Updated files based on go-ethereum 72c820c

TO-DO list

  • Fix Aura engine port for go since it is not working with parity-geth chain connection yet
  • Fix Aura engine port to work with several geth unittest ( Please check them with go run build/ci.go test )
    + Rebase commits with latest go-ethereum branch and squash them into 1 maybe?? ( Current files are updated with go-ethereum 72c820c commit you can rebase on top of it 😄 )

Here is the example pr opened for go-ethereum ethereum#17668

PS) Please check these compile errors with go linter

consensus/aura/aura.go:100:2:warning: unused variable or constant errInvalidCheckpointSigners (varcheck)
consensus/aura/aura.go:47:2:warning: unused variable or constant wiggleTime (varcheck)
consensus/aura/aura.go:71:2:warning: unused variable or constant errInvalidCheckpointBeneficiary (varcheck)
consensus/aura/aura.go:75:2:warning: unused variable or constant errInvalidVote (varcheck)
consensus/aura/aura.go:79:2:warning: unused variable or constant errInvalidCheckpointVote (varcheck)
consensus/aura/aura.go:83:2:warning: unused variable or constant errMissingVanity (varcheck)
consensus/aura/aura.go:91:2:warning: unused variable or constant errExtraSigners (varcheck)

@ghost ghost requested a review from holiman as a code owner September 13, 2018 12:46
5chdn
5chdn previously approved these changes Sep 13, 2018
@5chdn 5chdn added this to the 0.1 consensus engine milestone Sep 13, 2018
@ghost ghost changed the title cmd/utils, consensus/aura, core, eth, params: gofmt Cleanup for latest go-ethereum merge Sep 14, 2018
@5chdn 5chdn dismissed their stale review September 14, 2018 09:00

obsolete

Copy link

@5chdn 5chdn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please split gofmt and upstream changes in 2 PRs

and maintain upstream commit history please

+ Changed default goreli genesis block to match with Parity ( Still WIP, need fix on Aura engine )
+ Removed build-related files
@ghost
Copy link
Author

ghost commented Sep 14, 2018

@5chdn Done sorry for confusion 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants