Added the missing options in some commands and refactored some commands. #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added missing parameters in the (1) go client list function of the `repo` and `user` commands (2) go client getLogs function of the `logs.go` file in project command using options. Added the `XIsResourceName` parameter for the `GetProjectParams` function. And refactored the `view.go` file of project command. Refactored the `view.go` file of registry command: accessing the `credentialName`. Signed-off-by: muaz-32 <[email protected]>
bupd
force-pushed
the
add-missing-options-for-commands
branch
from
ab6aeee to
41725c0
Compare
Signed-off-by: bupd <[email protected]>
|
Ready for review |
bupd
added
the
Priority: Medium
Vad1mo
approved these changes
Jan 6, 2025
Standing-Man
pushed a commit
to Standing-Man/harbor-cli
that referenced
this pull request
Feb 5, 2025
…ds. (goharbor#77) * Added the missing options in some commands and refactored some commands. Added missing parameters in the (1) go client list function of the `repo` and `user` commands (2) go client getLogs function of the `logs.go` file in project command using options. Added the `XIsResourceName` parameter for the `GetProjectParams` function. And refactored the `view.go` file of project command. Refactored the `view.go` file of registry command: accessing the `credentialName`. Signed-off-by: muaz-32 <[email protected]> * remove inconsistencies Signed-off-by: bupd <[email protected]> --------- Signed-off-by: muaz-32 <[email protected]> Signed-off-by: bupd <[email protected]> Co-authored-by: bupd <[email protected]> Signed-off-by: Alan Tang <[email protected]>
Standing-Man
pushed a commit
to Standing-Man/harbor-cli
that referenced
this pull request
Feb 5, 2025
…ds. (goharbor#77) * Added the missing options in some commands and refactored some commands. Added missing parameters in the (1) go client list function of the `repo` and `user` commands (2) go client getLogs function of the `logs.go` file in project command using options. Added the `XIsResourceName` parameter for the `GetProjectParams` function. And refactored the `view.go` file of project command. Refactored the `view.go` file of registry command: accessing the `credentialName`. Signed-off-by: muaz-32 <[email protected]> * remove inconsistencies Signed-off-by: bupd <[email protected]> --------- Signed-off-by: muaz-32 <[email protected]> Signed-off-by: bupd <[email protected]> Co-authored-by: bupd <[email protected]>
Standing-Man
pushed a commit
to Standing-Man/harbor-cli
that referenced
this pull request
Feb 5, 2025
…ds. (goharbor#77) * Added the missing options in some commands and refactored some commands. Added missing parameters in the (1) go client list function of the `repo` and `user` commands (2) go client getLogs function of the `logs.go` file in project command using options. Added the `XIsResourceName` parameter for the `GetProjectParams` function. And refactored the `view.go` file of project command. Refactored the `view.go` file of registry command: accessing the `credentialName`. Signed-off-by: muaz-32 <[email protected]> * remove inconsistencies Signed-off-by: bupd <[email protected]> --------- Signed-off-by: muaz-32 <[email protected]> Signed-off-by: bupd <[email protected]> Co-authored-by: bupd <[email protected]> Signed-off-by: Alan Tang <[email protected]>
Standing-Man
pushed a commit
to Standing-Man/harbor-cli
that referenced
this pull request
Feb 5, 2025
…ds. (goharbor#77) * Added the missing options in some commands and refactored some commands. Added missing parameters in the (1) go client list function of the `repo` and `user` commands (2) go client getLogs function of the `logs.go` file in project command using options. Added the `XIsResourceName` parameter for the `GetProjectParams` function. And refactored the `view.go` file of project command. Refactored the `view.go` file of registry command: accessing the `credentialName`. Signed-off-by: muaz-32 <[email protected]> * remove inconsistencies Signed-off-by: bupd <[email protected]> --------- Signed-off-by: muaz-32 <[email protected]> Signed-off-by: bupd <[email protected]> Co-authored-by: bupd <[email protected]> Signed-off-by: Alan Tang <[email protected]>
Standing-Man
pushed a commit
to Standing-Man/harbor-cli
that referenced
this pull request
Feb 12, 2025
…ds. (goharbor#77) * Added the missing options in some commands and refactored some commands. Added missing parameters in the (1) go client list function of the `repo` and `user` commands (2) go client getLogs function of the `logs.go` file in project command using options. Added the `XIsResourceName` parameter for the `GetProjectParams` function. And refactored the `view.go` file of project command. Refactored the `view.go` file of registry command: accessing the `credentialName`. Signed-off-by: muaz-32 <[email protected]> * remove inconsistencies Signed-off-by: bupd <[email protected]> --------- Signed-off-by: muaz-32 <[email protected]> Signed-off-by: bupd <[email protected]> Co-authored-by: bupd <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #76
Added missing parameters in the
(1) go client
listfunction of therepoandusercommands(2) go client
getLogsfunction of thelogs.gofile in theprojectcommand using options.Added the
XIsResourceNameparameter for theGetProjectParamsfunction. This parameter specifies whether the input is name or ID.Refactored the
view.gofile of theprojectcommand.Refactored the
view.gofile of theregistrycommand: accessing thecredentialName.