-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revamp Copy Pull Command #21155
base: main
Are you sure you want to change the base?
Revamp Copy Pull Command #21155
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #21155 +/- ##
==========================================
+ Coverage 45.36% 46.08% +0.71%
==========================================
Files 244 248 +4
Lines 13333 13969 +636
Branches 2719 2886 +167
==========================================
+ Hits 6049 6438 +389
- Misses 6983 7191 +208
- Partials 301 340 +39
Flags with carried forward coverage won't be shown. Click here to find out more. |
This comment was marked as resolved.
This comment was marked as resolved.
61337ab
to
5f4a463
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
92e89c8
to
b0bab10
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Yes I do. |
There is a poll going regarding some UX aspects: Please vote if you didn't do so: |
This is something we really want. I did just want to make a suggestion and I hope it isn't too much work. In the preferences section, can you add "apptainer" and "singularity"? Or let those be defined by something in the config so the admins can set? As a harbor admin, I'd like to set a default container runtime based on the container tools we use for all users as well. |
This is a good idea. We will add a option in the dropdown where the user can define their prefered container runtime |
@bupd I have some comments for the UI design |
|
Also @AllForNothing, I have updated the PR description. We will not be removing the top copy field. Since its requested enhancement from the community. Poll: #21284 Thanks |
* This commit moves "Copy Pull Command" button inside the table * and add a separate column for better usability Signed-off-by: bupd <[email protected]>
* This Commit adds Preferences in navbar * Updates the navbar Signed-off-by: bupd <[email protected]>
Signed-off-by: bupd <[email protected]>
Signed-off-by: bupd <[email protected]>
Signed-off-by: bupd <[email protected]>
Signed-off-by: bupd <[email protected]>
Signed-off-by: bupd <[email protected]>
Signed-off-by: bupd <[email protected]>
Signed-off-by: bupd <[email protected]>
Signed-off-by: bupd <[email protected]>
Signed-off-by: bupd <[email protected]>
Signed-off-by: bupd <[email protected]>
* Updates title of preference settings * Updates container runtime to pull cmd prefix Signed-off-by: bupd <[email protected]>
* This commit adds custom as dropdown option * add custom_runtime localstorage variable for the pull prefix * fix artifact list tab styles * align copy icon in artifact tag list tab Signed-off-by: bupd <[email protected]>
Head branch was pushed to by a user without write access
ready for review and merge. |
* allow only lowercase alphabets Signed-off-by: bupd <[email protected]>
Added Live Demo to the Description. |
* removes unused in copy_pull_command in i18n in all languages Signed-off-by: bupd <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
src/portal/src/app/base/preference-settings/preference-settings.component.html
Outdated
Show resolved
Hide resolved
Signed-off-by: Prasanth Baskar <[email protected]>
One final comment from me, I'd like to see a "just the container name" option in the drop down in preferences, so, for example, I work with Helm charts a lot, and I'd like to just be able to copy the name of the image |
I think if you add helm registry as your custom command you would get helm registry pull ... as a string in your clipboard |
I'm frequently editing raw helm templates, or adding a specific repository as a value. I'm not looking for a "helm registry pull", as again, this then means I'm copying I do want to say, though, that I do much prefer this style that has been proposed. I'm just asking that while you're changing it, can you add my option to your list? :) |
Signed-off-by: Prasanth Baskar <[email protected]>
Overview
1 click > 3 clicks
UX should prioritize simplicity and clarity. By adding a copy button above and in the datagrid, similar to DockerHub and other registries, users can quickly copy exactly what they need with clear feedback, eliminating unnecessary clicks and improving overall UX.
After reviewing the discussion (#21284), the consensus is clear:
This design reduces friction and enhances usability.
Live DEMO
copy-pull-cmd.mp4
To-do:
Note
This design is based on thorough user feedback. As users mentioned,
Before
After (Updated copy pull command Flow)
artifact list page
tag list page
copy digest
copy tag
Added Preference Settings
updated Navbar
Added preferences section
Added multiple Pull Command Prefixes
closeup tooltip
Add Option to add Custom Pull Command Prefix
Summary of Changes Made
docker pull project/repo
).These changes revamp the user experience, reducing clicks and improving the flow for copying pull commands.
Issue being fixed
Fixes #21146
Please indicate you've done the following: