Suppress aborthandler #21479
Open
Suppress aborthandler #21479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…src (goharbor#21162) Bumps [go.opentelemetry.io/otel](https://github.com/open-telemetry/opentelemetry-go) from 1.31.0 to 1.32.0. - [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md) - [Commits](open-telemetry/opentelemetry-go@v1.31.0...v1.32.0) --- updated-dependencies: - dependency-name: go.opentelemetry.io/otel dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: miner <[email protected]>
Signed-off-by: ianseyer <[email protected]>
|
Thank you for your contribution, this is a quite common issue, we have also seen ourself. |
reasonerjt
reviewed
Feb 6, 2025
| case r == nil: | ||
| return | ||
|
|
||
| case ok && errors.Is(err, http.ErrAbortHandler): |
There was a problem hiding this comment.
Would be good to print a log with this error, just in case there are very frequent network connection issues.
There was a problem hiding this comment.
So there will, at least in my testing, still be http: proxy error: context canceled emitted if the connection is interrupted.
It is also worth mentioning that in net/http/server, this type of error is completely ignored: https://github.com/golang/go/blob/master/src/net/http/server.go#L1944
|
@reasonerjt what is the follow-up required? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18087, #15751, #10813, #12011, #16556, #20148
As per golang/go#28239, it is the expectation that middleware using net/http is responsible for handling http.AbortHandler panics that are automatically recovered.
In the current situation, any network connectivity blip, despite recovering successfully, results in a panic being written to the logs.
I have tested this build in our staging environment, and the panic message is indeed suppressed. We do see a proxy connection interrupted log message, which is to be expected (we have a reliable source of network connectivity blips).
Please indicate you've done the following: