-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
proposed fix for cryfs filesystem issue #1566
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even though the root cause comes from cryfs
and this is merely a workaround, I think it might be OK to merge this kind of patch, since the changes are relatively small. I am not sure what other scenarios result in a block count of 0 - if it does cause other issues we will have to revert this change, but hopefully that shouldn't be the case.
One other thing is that even with this workaround, because mtime
is now ignored I believe there's no way for lf
to automatically reload the directory if it changes (e.g. a new file is created), so the user will have to manually call reload
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the patch, I will give my approval.
I have bad news, it looks like tmpfs filesystems (e.g. Unless there's some other way to distinguish |
For issue #1543
Works on my machine for getting rid of the high cpu usage.
I can not seem to find a way to detect a cryfs file system that doesn't rely on syscall