use lowercase current_schema() method to support PgAdapter for GCP Spanner #1086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blaberg
force-pushed
the
lowercase-current-schema
branch
from
d6df9bf to
761152e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
We I have been experimenting with using the Postgres adapter for GCP Spanner that would let you use Postgres tools to interact with Spanner. However, it only supports the lowercase version of
CURRENT_SCHEMA(), which is used in the migration. This PR simply changes the function to the lowercase one. This will not effect any Postgres functionality, but will let people use the Postgres Adapter for Spanner.