-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Upgrade containerd and image-spec for the vulnerabilities #662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
go.mod
Outdated
github.com/cockroachdb/cockroach-go/v2 v2.1.1 | ||
github.com/containerd/containerd v1.5.8 // indirect |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
go.mod
Outdated
@@ -40,6 +41,7 @@ require ( | |||
github.com/mutecomm/go-sqlcipher/v4 v4.4.0 | |||
github.com/nakagami/firebirdsql v0.0.0-20190310045651-3c02a58cfed8 | |||
github.com/neo4j/neo4j-go-driver v1.8.1-0.20200803113522-b626aa943eba | |||
github.com/opencontainers/image-spec v1.0.2 // indirect |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -9,8 +9,9 @@ require ( | |||
github.com/apache/arrow/go/arrow v0.0.0-20211013220434-5962184e7a30 // indirect | |||
github.com/aws/aws-sdk-go v1.17.7 | |||
github.com/aws/aws-sdk-go-v2/feature/s3/manager v1.5.4 // indirect | |||
github.com/cenkalti/backoff/v4 v4.0.2 | |||
github.com/cenkalti/backoff/v4 v4.1.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Test Coverage Report for Build 1553106903
💛 - Coveralls |
My guess is that these dependencies are via dktest but there may be other packages that depend on these packages as well. I'm not too concerned about these from a security perspective since these packages should only be used when tests are running, so you shouldn't be vulnerable via |
Could you try updating dktest to v0.3.8 and run |
Thanks for your comment. Yes, I know that Thanks. |
github.com/cockroachdb/cockroach-go/v2 v2.1.1 | ||
github.com/cznic/mathutil v0.0.0-20180504122225-ca4c9f2c1369 // indirect | ||
github.com/denisenkom/go-mssqldb v0.10.0 | ||
github.com/dhui/dktest v0.3.7 | ||
github.com/dhui/dktest v0.3.8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dhui any chance for a new release with these changes? |
Any chance this can be put into release? |
Any Idea when this change can be released? |
@dhui ? |
I just updated dktest to v0.3.10 in migrate (master branch) which should fix known security issues and appease the security vulnerability scanners. If you'd also like to quiet your vulnerability scanners, use the master branch until the next release is cut. Although the master branch is not stable, any issues caused by recent changes (e.g. PR merges) will be promptly addressed. |
Background
We have used migrate in our applications and configured Dependabot alerts by GitHub.
It notified us that containerd and image-spec had vulnerabilities. But we don't use them directly.
Then, I created this PR to upgrade.
I am not sure how migrate use them 🙏