feat(spanner): Add option to disable closing spanner clients #910
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide an option to prevent the provided
*spanner.Client
and*database.DatabaseAdminClient
from being closed whenmigrate
closesSpanner
Spanner does not have the same concepts as PostgreSQL and MySQL, where it makes sense to use a
WithConnection()
function as the signature would be identical to that ofWithInstance()
. It could appear that they are interchangeable when really one closes the connection, and the other does not.I chose to take a simple path of adding an option to the
Config
,DoNotCloseSpannerClients
. This is a very simple change that is clear about its effect and does not change the default behavior ofWithInstance()
.But this is not in line with the other drivers implementing this same feature, so feels a little inconsistent.
Maybe someone has a better idea.
See the following thread for reference: