-
Notifications
You must be signed in to change notification settings - Fork 18k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/go, flag: make undefined flag msg less ambiguous. Fixes #36364 #37944
cmd/go, flag: make undefined flag msg less ambiguous. Fixes #36364 #37944
Conversation
This PR (HEAD: f0f3bf0) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/224017 to see it. Tip: You can toggle comments from me using the |
Message from Gobot Gobot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/224017. |
Message from Brian Onn: Patch Set 2: These are the related PR's that are affected by this change. golang/gofrontend#2 Please don’t reply on this GitHub thread. Visit golang.org/cl/224017. |
Message from Rob Pike: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/224017. |
Message from Rob Pike: Patch Set 2: By the way, I'm not sure it's worth the disruption to the ecosystem. I'll let others weigh in there. Please don’t reply on this GitHub thread. Visit golang.org/cl/224017. |
Message from Brian Onn: Patch Set 2: (1 comment)
Although I authored this change, I also agree with your sentiment here. Please don’t reply on this GitHub thread. Visit golang.org/cl/224017. |
Message from Ian Lance Taylor: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/224017. |
Message from Go Bot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/224017. |
This fix tries to improve the error message from an undefined flag as discussed in issue #36364 Changing this error message unfortunately has a high impact on 3rd party tools and editors that monitor the go command stderr output for the error message that is changed here. Any tool that imports the flag package will be affected. Vscode-go plugin and likely other editors and tools will be affected. I have also completed the matching changes neeeded for golang/tools, golang/dep, golang/gofrontend and microsoft/vscode-go. I'll link them in here after I create the corresponding PR's for them all
golang/gofrontend#2
golang/dep#2238
golang/tools#216
microsoft/vscode-go#3113