New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go/packages: optimize loading without overlays #160

Open

jirfag wants to merge 1 commit into golang:master from golangci:speedup-go-packages-loading

+27 −13

Contributor

jirfag commented Sep 14, 2019

Both of determineEnv and determineRootDirs calls take 100-200ms on
MacBook Pro. Right now they are needed in most cases only for
overlay processing. Optimize: call them only when overlays are set.


          go/packages: optimize loading without overlays

e9260b9

Both of determineEnv and determineRootDirs calls take 100-200ms on
MacBook Pro. Right now they are needed in most cases only for
overlay processing. Optimize: call them only when overlays are set.

googlebot added the cla: yes label

Contributor

gopherbot commented Sep 14, 2019

This PR (HEAD: e9260b9) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/195357 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Contributor

gopherbot commented Sep 16, 2019

Message from Michael Matloob:

Patch Set 1: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/195357.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Sep 16, 2019

Message from Gobot Gobot:

Patch Set 1:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=2fb79fc0

Please don’t reply on this GitHub thread. Visit golang.org/cl/195357.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Sep 16, 2019

Message from Michael Matloob:

Patch Set 1:

Is this calling slowness? We shouldn't be blocking on determineEnv or determineRootDirs, right?

Please don’t reply on this GitHub thread. Visit golang.org/cl/195357.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Sep 16, 2019

Message from Gobot Gobot:

Patch Set 1: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/195357.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Sep 17, 2019

Message from Denis Isaev:

Patch Set 1:

Patch Set 1:

Is this calling slowness? We shouldn't be blocking on determineEnv or determineRootDirs, right?

Yes, on my MacBook pro the final loading time was 100-200ms slower even it's parallel.

Please don’t reply on this GitHub thread. Visit golang.org/cl/195357.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Sep 26, 2019

Message from Michael Matloob:

Patch Set 1:

Patch Set 1:

Patch Set 1:

Is this calling slowness? We shouldn't be blocking on determineEnv or determineRootDirs, right?

Yes, on my MacBook pro the final loading time was 100-200ms slower even it's parallel.

Do you know why that's happening? I don't want to make this change without understanding how it helps.

Please don’t reply on this GitHub thread. Visit golang.org/cl/195357.
After addressing review feedback, remember to publish your drafts!

gopherbot force-pushed the master branch from 9cd7e18 to b917058 Compare

October 4, 2019 02:21

ernado mentioned this pull request

Update to latest x/tools golangci/golangci-lint#930

Merged

Contributor

gopherbot commented Oct 15, 2020

Message from Go Bot:

Patch Set 1:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=2fb79fc0

Please don’t reply on this GitHub thread. Visit golang.org/cl/195357.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Oct 15, 2020

Message from Go Bot:

Patch Set 1: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/195357.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels