Skip to content

Conversation

@lucor
Copy link

@lucor lucor commented Mar 21, 2018

This pull request add support for quote.

The template uses the function "quote" to inject quotes and citations.

The text after ".quote" is embedded in a blockquote element after
processing styling. The text after the optional "//CITATION:" is treated
as a citation and embedded in a cite element after processing styling.

.quote Never memorize something that you can look up //CITATION: Albert Einstein

The template uses the function "quote" to inject quotes and citations.

The text after ".quote" is embedded in a blockquote element after
processing styling. The text after the optional "//CITATION:" is treated
as a citation and embedded in a cite element after processing styling.

	.quote Never memorize something that you can look up //CITATION: Albert Einstein

Change-Id: I891285928410cea1d289f05b9b5e8599ffaa79b6
@gopherbot
Copy link
Contributor

This PR (HEAD: 841c231) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/#/c/tools/+/101795 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/101795.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit Bot:

Uploaded patch set 2: Commit message was updated.


Please don’t reply on this GitHub thread. Visit golang.org/cl/101795.
After addressing review feedback, remember to publish your drafts!

@lucor lucor changed the title tools/present: add support for quote present: add support for quote Mar 21, 2018
@gopherbot
Copy link
Contributor

Message from Gerrit Bot:

Uploaded patch set 3: Commit message was updated.


Please don’t reply on this GitHub thread. Visit golang.org/cl/101795.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit Bot:

Uploaded patch set 4: Commit message was updated.


Please don’t reply on this GitHub thread. Visit golang.org/cl/101795.
After addressing review feedback, remember to publish your drafts!

The template uses the function "quote" to inject quotes and citations.

The text after ".quote" is embedded in a blockquote element after
processing styling. The text after the optional "//CITATION:" is treated
as a citation and embedded in a cite element after processing styling.

	.quote Never memorize something that you can look up //CITATION: Albert Einstein

Change-Id: I891285928410cea1d289f05b9b5e8599ffaa79b6
@gopherbot
Copy link
Contributor

Message from Tobias Klauser:

Patch Set 4:

(2 comments)

Thanks


Please don’t reply on this GitHub thread. Visit golang.org/cl/101795.
After addressing review feedback, remember to publish your drafts!

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@gopherbot
Copy link
Contributor

This PR (HEAD: e0a7e3e) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/#/c/tools/+/101795 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

lucor added 6 commits April 5, 2018 11:02
The template uses the function "quote" to inject quotes and citations.

The text after ".quote" is embedded in a blockquote element after
processing styling. The text after the optional "//CITATION:" is treated
as a citation and embedded in a cite element after processing styling.

	.quote Never memorize something that you can look up //CITATION: Albert Einstein

Change-Id: I891285928410cea1d289f05b9b5e8599ffaa79b6
@googlebot
Copy link

CLAs look good, thanks!

Googlers can find more info about SignCLA and this PR by following this link.

@gopherbot
Copy link
Contributor

Message from Luca Corbo:

Patch Set 5:

(2 comments)

Fixed, thanks.


Please don’t reply on this GitHub thread. Visit golang.org/cl/101795.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Luca Corbo:

Patch Set 5:

I'm sorry but probably I've messed up something trying to rebase adding these new commits that are not reported here in gerrit now:

Is there anything I can do in order to fix this ?
Thanks


Please don’t reply on this GitHub thread. Visit golang.org/cl/101795.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Andrew Gerrand:

Patch Set 5:

cc andybons for the gerrit/github issue


Please don’t reply on this GitHub thread. Visit golang.org/cl/101795.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Andrew Bonventre:

Patch Set 5:

Patch Set 5:

I'm sorry but probably I've messed up something trying to rebase adding these new commits that are not reported here in gerrit now:

Is there anything I can do in order to fix this ?
Thanks

Is your local fork up to date? What were your rebase steps?


Please don’t reply on this GitHub thread. Visit golang.org/cl/101795.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Luca Corbo:

Patch Set 5:

Patch Set 5:

Patch Set 5:

I'm sorry but probably I've messed up something trying to rebase adding these new commits that are not reported here in gerrit now:

Is there anything I can do in order to fix this ?
Thanks

Is your local fork up to date? What were your rebase steps?

I'm sorry but I'm unable to recall the exact steps I did :(
The remote fork is up to date with all commits: master...lucor:feature/add-support-for-quote


Please don’t reply on this GitHub thread. Visit golang.org/cl/101795.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Luca Corbo:

Patch Set 6:

Patch Set 6:

Patch Set 6:

(1 comment)

Patch Set 5:

(1 comment)

Is there a corresponding issue proposing this change per golang.org/s/proposal?

Apologies, I've missed that step. Only created the PR against golang/tools. Should I create a proposal pointing to this PR ?

Yes, that would be great. Thank you.

Proposal link: golang/go#30343


Please don’t reply on this GitHub thread. Visit golang.org/cl/101795.
After addressing review feedback, remember to publish your drafts!

@gopherbot gopherbot force-pushed the master branch 3 times, most recently from 88641d9 to db1ebf7 Compare October 4, 2019 03:45
@gopherbot gopherbot force-pushed the master branch 13 times, most recently from 8185551 to dc03839 Compare November 5, 2019 20:21
WenzheLiu pushed a commit to WenzheLiu/tools that referenced this pull request Nov 29, 2019
* commit '69a357cc3887d351774ea41076ab9d45569fb11e':
  skip TLS
@gopherbot
Copy link
Contributor

Message from Gerrit User 5976:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/101795.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit User 19560:

Patch Set 4:

(2 comments)

Thanks


Please don’t reply on this GitHub thread. Visit golang.org/cl/101795.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit User 26935:

Patch Set 5:

(2 comments)

Fixed, thanks.


Please don’t reply on this GitHub thread. Visit golang.org/cl/101795.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit User 26935:

Patch Set 5:

I'm sorry but probably I've messed up something trying to rebase adding these new commits that are not reported here in gerrit now:

Is there anything I can do in order to fix this ?
Thanks


Please don’t reply on this GitHub thread. Visit golang.org/cl/101795.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit User 5010:

Patch Set 5:

cc andybons for the gerrit/github issue


Please don’t reply on this GitHub thread. Visit golang.org/cl/101795.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit User 22285:

Patch Set 5:

Patch Set 5:

I'm sorry but probably I've messed up something trying to rebase adding these new commits that are not reported here in gerrit now:

Is there anything I can do in order to fix this ?
Thanks

Is your local fork up to date? What were your rebase steps?


Please don’t reply on this GitHub thread. Visit golang.org/cl/101795.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit User 26935:

Patch Set 5:

Patch Set 5:

Patch Set 5:

I'm sorry but probably I've messed up something trying to rebase adding these new commits that are not reported here in gerrit now:

Is there anything I can do in order to fix this ?
Thanks

Is your local fork up to date? What were your rebase steps?

I'm sorry but I'm unable to recall the exact steps I did :(
The remote fork is up to date with all commits: master...lucor:feature/add-support-for-quote


Please don’t reply on this GitHub thread. Visit golang.org/cl/101795.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Andrew Bonventre:

Patch Set 5:

(1 comment)

Is there a corresponding issue proposing this change per golang.org/s/proposal?


Please don’t reply on this GitHub thread. Visit golang.org/cl/101795.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Luca Corbo:

Patch Set 6:

(1 comment)

Patch Set 5:

(1 comment)

Is there a corresponding issue proposing this change per golang.org/s/proposal?

Apologies, I've missed that step. Only created the PR against golang/tools. Should I create a proposal pointing to this PR ?


Please don’t reply on this GitHub thread. Visit golang.org/cl/101795.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Andrew Bonventre:

Patch Set 6:

Patch Set 6:

(1 comment)

Patch Set 5:

(1 comment)

Is there a corresponding issue proposing this change per golang.org/s/proposal?

Apologies, I've missed that step. Only created the PR against golang/tools. Should I create a proposal pointing to this PR ?

Yes, that would be great. Thank you.


Please don’t reply on this GitHub thread. Visit golang.org/cl/101795.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Luca Corbo:

Patch Set 6:

Patch Set 6:

Patch Set 6:

(1 comment)

Patch Set 5:

(1 comment)

Is there a corresponding issue proposing this change per golang.org/s/proposal?

Apologies, I've missed that step. Only created the PR against golang/tools. Should I create a proposal pointing to this PR ?

Yes, that would be great. Thank you.

Proposal link: golang/go#30343


Please don’t reply on this GitHub thread. Visit golang.org/cl/101795.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants