-
Notifications
You must be signed in to change notification settings - Fork 2.4k
present: add support for quote #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
The template uses the function "quote" to inject quotes and citations. The text after ".quote" is embedded in a blockquote element after processing styling. The text after the optional "//CITATION:" is treated as a citation and embedded in a cite element after processing styling. .quote Never memorize something that you can look up //CITATION: Albert Einstein Change-Id: I891285928410cea1d289f05b9b5e8599ffaa79b6
|
This PR (HEAD: 841c231) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/#/c/tools/+/101795 to see it. Tip: You can toggle comments from me using the |
|
Message from Gobot Gobot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/101795. |
|
Message from Gerrit Bot: Uploaded patch set 2: Commit message was updated. Please don’t reply on this GitHub thread. Visit golang.org/cl/101795. |
|
Message from Gerrit Bot: Uploaded patch set 3: Commit message was updated. Please don’t reply on this GitHub thread. Visit golang.org/cl/101795. |
|
Message from Gerrit Bot: Uploaded patch set 4: Commit message was updated. Please don’t reply on this GitHub thread. Visit golang.org/cl/101795. |
The template uses the function "quote" to inject quotes and citations. The text after ".quote" is embedded in a blockquote element after processing styling. The text after the optional "//CITATION:" is treated as a citation and embedded in a cite element after processing styling. .quote Never memorize something that you can look up //CITATION: Albert Einstein Change-Id: I891285928410cea1d289f05b9b5e8599ffaa79b6
|
Message from Tobias Klauser: Patch Set 4: (2 comments) Thanks Please don’t reply on this GitHub thread. Visit golang.org/cl/101795. |
…to feature/add-support-for-quote
Signed-off-by: lucor <[email protected]>
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
|
This PR (HEAD: e0a7e3e) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/#/c/tools/+/101795 to see it. Tip: You can toggle comments from me using the |
The template uses the function "quote" to inject quotes and citations. The text after ".quote" is embedded in a blockquote element after processing styling. The text after the optional "//CITATION:" is treated as a citation and embedded in a cite element after processing styling. .quote Never memorize something that you can look up //CITATION: Albert Einstein Change-Id: I891285928410cea1d289f05b9b5e8599ffaa79b6
Signed-off-by: lucor <[email protected]>
…to feature/add-support-for-quote
Signed-off-by: lucor <[email protected]>
|
CLAs look good, thanks! Googlers can find more info about SignCLA and this PR by following this link. |
|
Message from Luca Corbo: Patch Set 5: (2 comments) Fixed, thanks. Please don’t reply on this GitHub thread. Visit golang.org/cl/101795. |
|
Message from Luca Corbo: Patch Set 5: I'm sorry but probably I've messed up something trying to rebase adding these new commits that are not reported here in gerrit now: Is there anything I can do in order to fix this ? Please don’t reply on this GitHub thread. Visit golang.org/cl/101795. |
|
Message from Andrew Gerrand: Patch Set 5: cc andybons for the gerrit/github issue Please don’t reply on this GitHub thread. Visit golang.org/cl/101795. |
|
Message from Andrew Bonventre: Patch Set 5:
Is your local fork up to date? What were your rebase steps? Please don’t reply on this GitHub thread. Visit golang.org/cl/101795. |
|
Message from Luca Corbo: Patch Set 5:
I'm sorry but I'm unable to recall the exact steps I did :( Please don’t reply on this GitHub thread. Visit golang.org/cl/101795. |
|
Message from Luca Corbo: Patch Set 6:
Proposal link: golang/go#30343 Please don’t reply on this GitHub thread. Visit golang.org/cl/101795. |
88641d9 to
db1ebf7
Compare
8185551 to
dc03839
Compare
* commit '69a357cc3887d351774ea41076ab9d45569fb11e': skip TLS
|
Message from Gerrit User 5976: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/101795. |
|
Message from Gerrit User 19560: Patch Set 4: (2 comments) Thanks Please don’t reply on this GitHub thread. Visit golang.org/cl/101795. |
|
Message from Gerrit User 26935: Patch Set 5: (2 comments) Fixed, thanks. Please don’t reply on this GitHub thread. Visit golang.org/cl/101795. |
|
Message from Gerrit User 26935: Patch Set 5: I'm sorry but probably I've messed up something trying to rebase adding these new commits that are not reported here in gerrit now: Is there anything I can do in order to fix this ? Please don’t reply on this GitHub thread. Visit golang.org/cl/101795. |
|
Message from Gerrit User 5010: Patch Set 5: cc andybons for the gerrit/github issue Please don’t reply on this GitHub thread. Visit golang.org/cl/101795. |
|
Message from Gerrit User 22285: Patch Set 5:
Is your local fork up to date? What were your rebase steps? Please don’t reply on this GitHub thread. Visit golang.org/cl/101795. |
|
Message from Gerrit User 26935: Patch Set 5:
I'm sorry but I'm unable to recall the exact steps I did :( Please don’t reply on this GitHub thread. Visit golang.org/cl/101795. |
|
Message from Andrew Bonventre: Patch Set 5: (1 comment) Is there a corresponding issue proposing this change per golang.org/s/proposal? Please don’t reply on this GitHub thread. Visit golang.org/cl/101795. |
|
Message from Luca Corbo: Patch Set 6: (1 comment)
Apologies, I've missed that step. Only created the PR against golang/tools. Should I create a proposal pointing to this PR ? Please don’t reply on this GitHub thread. Visit golang.org/cl/101795. |
|
Message from Andrew Bonventre: Patch Set 6:
Yes, that would be great. Thank you. Please don’t reply on this GitHub thread. Visit golang.org/cl/101795. |
|
Message from Luca Corbo: Patch Set 6:
Proposal link: golang/go#30343 Please don’t reply on this GitHub thread. Visit golang.org/cl/101795. |
This pull request add support for quote.
The template uses the function "quote" to inject quotes and citations.
The text after ".quote" is embedded in a blockquote element after
processing styling. The text after the optional "//CITATION:" is treated
as a citation and embedded in a cite element after processing styling.