Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/ssa: add associated documentation to functions #47

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aykevl
Copy link
Contributor

@aykevl aykevl commented Aug 26, 2018

This makes it easier for clients to read compiler directives like //go:linkname or //line.

I would like to use this in my own Go compiler project.

This makes it easier for clients to read compiler directives like
//go:linkname or //line.
@gopherbot
Copy link
Contributor

Message from Gerrit User 5976:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/131283.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit User 5195:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/131283.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit User 5020:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/131283.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit User 5195:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/131283.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Alan Donovan:

Patch Set 1: Code-Review-1


Please don’t reply on this GitHub thread. Visit golang.org/cl/131283.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Ayke van Laethem:

Patch Set 1:

Oops, I forgot about this change. I have used you


Please don’t reply on this GitHub thread. Visit golang.org/cl/131283.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Ayke van Laethem:

Patch Set 1:

Patch Set 1:

Oops, I forgot about this change. I have used you

*I have used your change and it has worked well for me. (Hit the wrong button).


Please don’t reply on this GitHub thread. Visit golang.org/cl/131283.
After addressing review feedback, remember to publish your drafts!

@gopherbot gopherbot force-pushed the master branch 3 times, most recently from 88641d9 to db1ebf7 Compare October 4, 2019 03:45
@gopherbot gopherbot force-pushed the master branch 10 times, most recently from 8185551 to dc03839 Compare November 5, 2019 20:21
gofera pushed a commit to gofera/tools that referenced this pull request Jan 31, 2020
… dev

* commit '051a366f6d968396962d66a39c3f216fd01f0042':
  support -scroll and -style in graphviz
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants