test: add unit tests for tools module#587
Open
stanley1208 wants to merge 1 commit intogoogle-deepmind:mainfrom
Open
test: add unit tests for tools module#587stanley1208 wants to merge 1 commit intogoogle-deepmind:mainfrom
stanley1208 wants to merge 1 commit intogoogle-deepmind:mainfrom
Conversation
The tools module (gemma/gm/tools/) had zero test coverage. This adds 19 tests covering: Tool base class (3 tests): name property, argnames introspection, call method Calculator (6 tests): arithmetic, compound expressions, math/trig functions, name, argnames Tool manager (10 tests): JSON parsing, text extraction, invalid input handling, tool execution, unknown tools, system prompt generation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The tools module (
gemma/gm/tools/) had zero test coverage. This PR adds 19 unit tests covering theToolbase class,Calculator, andOneShotToolManager.Tests added (
_tools_test.py— 19 tests)Tool base class (3 tests):
test_tool_name: name property returns lowercase class nametest_tool_argnames: introspects call signature correctlytest_tool_call: basic call works with kwargsCalculator (6 tests):
test_calculator_basic_arithmetic: +, -, *, /test_calculator_compound_expression:25 * 4 + 10 = 110test_calculator_math_functions: sqrt, floor, ceiltest_calculator_trig_functions: sin(0), cos(0)test_calculator_name: returns'calculator'test_calculator_argnames: returns('expression',)Tool manager (10 tests):
test_parse_tool_call_valid_json: parses valid JSON tool calltest_parse_tool_call_json_in_text: extracts JSON embedded in texttest_parse_tool_call_no_json: returns None for plain texttest_parse_tool_call_invalid_json: returns None for malformed JSONtest_format_tool_result: correct formattingtest_tool_manager_execute_calculator: end-to-end tool executiontest_tool_manager_no_tool_call: returns None for non-tool outputtest_tool_manager_unknown_tool: handles unregistered tools gracefullytest_tool_manager_system_prompt_contains_tool: prompt includes tool infotest_tool_manager_name_to_tool: name-to-tool mapping works correctlyTest plan
pytest -vv gemma/gm/tools/_tools_test.py)