Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency in how model name is supplied in the library. #466

Open
LindaLawton opened this issue Jul 18, 2024 · 4 comments
Open

Inconsistency in how model name is supplied in the library. #466

LindaLawton opened this issue Jul 18, 2024 · 4 comments
Assignees
Labels
component:python sdk Issue/PR related to Python SDK status:triaged Issue/PR triaged to the corresponding sub-team type:feature request New feature request/enhancement

Comments

@LindaLawton
Copy link

Description of the feature request:

Embedings requiers models/

result = genai.embed_content(
    model="models/embedding-001",
    content="What is the meaning of life?",
    task_type="retrieval_document",
    title="Embedding of single string")

# 1 input > 1 vector output
print(str(result['embedding'])[:50], '... TRIMMED]')

All other methos do not require it

  model = genai.GenerativeModel('gemini-1.5-flash')

What problem are you trying to solve with this feature?

Consistency

Any other information you'd like to share?

#justsaying

@singhniraj08 singhniraj08 added type:feature request New feature request/enhancement status:triaged Issue/PR triaged to the corresponding sub-team component:python sdk Issue/PR related to Python SDK labels Jul 24, 2024
@MarkDaoust
Copy link
Collaborator

Right, thanks.

@shilpakancharla IIRC you did the embedding implementation, could you fix this?

@LindaLawton
Copy link
Author

I'm happy to try to implement it if you like.

@shilpakancharla
Copy link
Collaborator

HI @LindaLawton , please feel free to submit an implementation.

@bhakarboy01
Copy link

bhakarboy01 commented Mar 15, 2025

@MarkDaoust @shilpakancharla @LindaLawton I have made the code consistent with the model naming without "model/" prefix in genai.embed_content function. PR #718

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:python sdk Issue/PR related to Python SDK status:triaged Issue/PR triaged to the corresponding sub-team type:feature request New feature request/enhancement
Projects
None yet
Development

No branches or pull requests

5 participants