Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added consistency in embed model names #718

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bhakarboy01
Copy link

@bhakarboy01 bhakarboy01 commented Mar 15, 2025

Description of the change

added consistency for model names in embed_content function

Now, genai.embed_content function doesn't require a prefix of models/

Can be directly used as genai.embed_content( model="embedding-001", content="What is the meaning of life?", task_type="retrieval_document", title="Embedding of single string")

Motivation

Fixed consistency issue #466

Type of change

Feature request

Checklist

  • I have performed a self-review of my code.
  • I have added detailed comments to my code where applicable.
  • I have verified that my change does not break existing code.
  • My PR is based on the latest changes of the main branch (if unsure, please run git pull --rebase upstream main).
  • I am familiar with the Google Style Guide for the language I have coded in.
  • I have read through the Contributing Guide and signed the Contributor License Agreement.

@github-actions github-actions bot added status:awaiting review PR awaiting review from a maintainer component:python sdk Issue/PR related to Python SDK labels Mar 15, 2025
@bhakarboy01
Copy link
Author

@MarkDaoust Please review this PR

@Annhiluc Annhiluc added status:triaged Issue/PR triaged to the corresponding sub-team p2 labels Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:python sdk Issue/PR related to Python SDK p2 status:awaiting review PR awaiting review from a maintainer status:triaged Issue/PR triaged to the corresponding sub-team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants