Async for files.py functions #586
Conversation
github-actions
bot
added
status:awaiting review
| @@ -97,6 +111,10 @@ def list_files(page_size=100) -> Iterable[file_types.File]: | |||
| yield file_types.File(proto) | |||
|
|
|||
|
|
|||
| async def list_files_async(*args, **kwargs): | |||
There was a problem hiding this comment.
I think this will fail because we want an async iterator to be returned here.
Can you copy the list_files code and add the missing asyncs?
| @@ -105,6 +123,10 @@ def get_file(name: str) -> file_types.File: | |||
| return file_types.File(client.get_file(name=name)) | |||
|
|
|||
|
|
|||
| async def get_file_async(*args, **kwargs): | |||
| return await asyncio.to_thread(get_file, *args, **kwargs) | |||
There was a problem hiding this comment.
We have an async client, we should use it. Let's copy-paste the code, and add the missing asyncs
| @@ -114,3 +136,7 @@ def delete_file(name: str | file_types.File | protos.File): | |||
| request = protos.DeleteFileRequest(name=name) | |||
| client = get_default_file_client() | |||
| client.delete_file(request=request) | |||
|
|
|||
|
|
|||
| async def delete_file_async(*args, **kwargs): | |||
| @@ -127,5 +130,29 @@ def test_files_delete(self): | |||
| # [END files_delete] | |||
|
|
|||
|
|
|||
| class AsyncTests(absltest.TestCase, unittest.IsolatedAsyncioTestCase): | |||
There was a problem hiding this comment.
We should test all the methods, I think list is broken right now.
There was a problem hiding this comment.
When sieving through the code I saw that the SDK does have a FileServiceAsyncClient class in client.py, but there are no corresponding async examples in the samples/files.py file. There is missing AsyncTests class with async test method for checking the list. If the issue is open I would love to work on this.
|
Is this issue open? |
Annhiluc
added
type:feature request
Added
asynciomethods for all the file methods.However, how should we test these
asynciomethods?