Improve key naming clarity and consistency across REST requests #683 #714
Conversation
… Standardize on camelCase for REST API parameter names - Update README.md to document parameter naming conventions - Create new inline_pdf_example.sh with consistent naming - Fix inconsistent naming in several example files - Fixes google-gemini#683
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
github-actions
bot
added
status:awaiting review
There was a problem hiding this comment.
Need to apply the consistency changes to the following files:
- samples/rest/count_tokens.sh lines:116-118, line:174, lines:274-275
- samples/rest/function_calling.sh lines:48-49
- samples/rest/text_generation.sh line:213, line:263, line:324, line:384, line:434, line:486
I have left the comments on the relevant files too.
Other than that it looks fine to me (creator of the issue).
There was a problem hiding this comment.
Need to apply the consistency changes to the following places:
- samples/rest/text_generation.sh line:213, line:263, line:324, line:384, line:434, line:486
There was a problem hiding this comment.
I will fix this immediately
There was a problem hiding this comment.
Need to apply the consistency changes to the following files:
- samples/rest/function_calling.sh lines:48-49
There was a problem hiding this comment.
Need to apply the consistency changes to the following files:
- samples/rest/count_tokens.sh lines:116-118, line:174, lines:274-275
|
I have made the asked changes let me know if its upto mark |
|
Looks good to me but I believe these examples need to be verified and tested by someone internal to Google before they can proceed with merging the PR and closing the issue. |
|
Thanks. If anything else is needed or any changes. I am always up for it |
… Standardize on camelCase for REST API parameter names - Update README.md to document parameter naming conventions - Create new inline_pdf_example.sh with consistent naming - Fix inconsistent naming in several example files - Fixes #683
Description of the change
Motivation
Type of change
Choose one: (Bug fix | Feature request | Documentation | Other)
Checklist
git pull --rebase upstream main).