SFst: Support modern token aliases for sentence boundary symbols in WriteArpa. - #19
Merged
Merged
Conversation
copybara-service
Bot
force-pushed
the
copybara/964629362
branch
2 times, most recently
from
August 14, 2026 17:14
cc7a994 to
60f5c6a
Compare
…riteArpa. Expands BOS candidate lookup to check `<s>`, `<S>`, `<bos>`, `<BOS>`, and `[BOS]`, and EOS candidate lookup to check `</s>`, `</S>`, `<eos>`, `<EOS>`, and `[EOS]`. Logs a warning when no known EOS alias is found before defaulting to `</s>`. Adds a unit test verifying modern `<bos>/<eos>` tokens. Strictly speaking, the ARPA file format specification itself only dictates syntax and structure (`\data\, \N-grams:, <log10_prob> <words...> [<log10_backoff>], \end\`). It does not mandate specific reserved lexical strings for sentence boundaries—any whitespace-free token string is syntactically valid ARPA. PiperOrigin-RevId: 964762723
copybara-service
Bot
force-pushed
the
copybara/964629362
branch
from
August 14, 2026 17:19
60f5c6a to
4be878d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SFst: Support modern token aliases for sentence boundary symbols in WriteArpa.
Expands BOS candidate lookup to check
<s>,<S>,<bos>,<BOS>, and[BOS],and EOS candidate lookup to check
</s>,</S>,<eos>,<EOS>, and[EOS].Logs a warning when no known EOS alias is found before defaulting to
</s>. Adds a unit test verifying modern<bos>/<eos>tokens.Strictly speaking, the ARPA file format specification itself only dictates syntax and structure (
\data\, \N-grams:, <log10_prob> <words...> [<log10_backoff>], \end\). It does not mandate specific reserved lexical strings for sentence boundaries—any whitespace-free token string is syntactically valid ARPA.