Merge pull request #228 from davidmorgan/no-computenode

Remove an unneeded use of computeNode in generator.
google · Sep 14, 2017 · cb0c445 · cb0c445
2 parents 67055d3 + 45a8aad
commit cb0c445
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,9 +2,10 @@
 
 ## 4.1.1 (unreleased)
 
-- Generated code now tells the analyzer to ignore prefer_expression_function_bodies
-  and sort_constructors_first.
-
+- Generated code now tells the analyzer to ignore
+  prefer_expression_function_bodies and sort_constructors_first.
+- Remove an unneeded use of computeNode in generator; improves generator
+  performance.
 
 ## 4.1.0
 

diff --git a/built_value_generator/lib/src/serializer_source_field.dart b/built_value_generator/lib/src/serializer_source_field.dart
@@ -86,6 +86,9 @@ abstract class SerializerSourceField
         type, classGenericParameters ?? new BuiltSet<String>());
   }
 
+  @memoized
+  bool get needsBuilder => element.getter.returnType.displayName.contains('<');
+
   /// Generates a cast using 'as' to this field type.
   ///
   /// Generics are cast to the bound of the generic. If there is no bound,
@@ -95,8 +98,6 @@ abstract class SerializerSourceField
     return result == 'Object' ? '' : 'as $result';
   }
 
-  bool get needsBuilder => type.contains('<');
-
   String generateBuilder() {
     final bareType = _getBareType(type);
     if (typesWithBuilder.containsKey(bareType)) {

diff --git a/built_value_generator/lib/src/serializer_source_field.g.dart b/built_value_generator/lib/src/serializer_source_field.g.dart