-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "reduce_logs_for_kubelet_use_crio" #3565
Conversation
This reverts commit b407dcd.
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Hi @uablrek. Thanks for your PR. I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
xref: #3457 |
/ok-to-test |
/approve |
I have verified that the revert fixes the problem by copying
My metrics test works. They fail for crio without this PR (but works with containerd) |
This reverts commit b407dcd.
Fixes #3538
There may be a better way by detecting if cgroups are managed by systemd, but I have not enough knowledge of cadvisor, and not much time. So, the easy way out is to revert the commit causing the problem.
Further, I don't even know how to test it. I use K8s with cri-o, but cadvisor is vendored in K8s, so I don't know how to make K8s use this branch (I know howto build and test K8s from master though)