docker: migrate to github.com/moby/moby modules #3757
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
commented
Dec 4, 2025
container/docker/handler.go
Outdated
Comment on lines
239
to
253
| c := ctnr | ||
| if networkMode.IsContainer() { | ||
| containerID := networkMode.ConnectedContainer() | ||
| res, err := client.ContainerInspect(context.Background(), containerID, dclient.ContainerInspectOptions{}) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("failed to inspect container %q: %v", id, err) | ||
| } | ||
| ipAddress = c.NetworkSettings.IPAddress | ||
| c = res.Container | ||
| } | ||
| for n, nw := range c.NetworkSettings.Networks { | ||
| if n == c.HostConfig.NetworkMode.NetworkName() { | ||
| if nw.IPAddress.IsValid() { | ||
| handler.ipAddress = nw.IPAddress.String() | ||
| } | ||
| } |
Contributor
Author
There was a problem hiding this comment.
cc @robmry perhaps you could have a peek if this is the correct approach for the IP-address
Contributor
Author
|
cc @dims if you can give CI a kick to have it run 😅 |
thaJeztah
commented
Dec 4, 2025
| dockerClient, dockerClientErr = dclient.New( | ||
| dclient.WithHost(*ArgDockerEndpoint), | ||
| dclient.WithHTTPClient(client), | ||
| dclient.WithAPIVersionNegotiation()) |
Contributor
Author
There was a problem hiding this comment.
This is now enabled by default
thaJeztah
force-pushed
the
switch_moby_modules
branch
from
70c045c to
f0de6b6
Compare
Collaborator
Done! |
Contributor
Author
|
Ah, thanks! And looks like I missed some change somewhere; let me have a look 👍 |
thaJeztah
force-pushed
the
switch_moby_modules
branch
from
f0de6b6 to
632e89a
Compare
1 task
thaJeztah
force-pushed
the
switch_moby_modules
branch
2 times, most recently
from
38f7d98 to
2442160
Compare
full diff: docker/go-connections@v0.5.0...v0.6.0 Signed-off-by: Sebastiaan van Stijn <[email protected]>
The top-level IPAddress field is deprecated in the API, so instead, the IP-address should be obtained from the container's primary network. Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
switch_moby_modules
branch
from
2442160 to
cfbcb5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.