Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to embedded-hal 1.0 #1723

Merged
merged 3 commits into from
Apr 19, 2024
Merged

Update to embedded-hal 1.0 #1723

merged 3 commits into from
Apr 19, 2024

Conversation

qwandor
Copy link
Collaborator

@qwandor qwandor commented Jan 18, 2024

Now that the new version of microbit-v2 and friends are finally released, we can use embedded-hal 1.0 for the bare metal morning.

@qwandor qwandor force-pushed the embedded-hal branch 2 times, most recently from beaabbd to 3e167af Compare January 18, 2024 12:10
@randomPoison
Copy link
Collaborator

I just merged a couple of PRs that bump the crate version, but I'd like to merge your cleanup of embedded-hal.md. @qwandor can you rebase this on top of main? I'll approve and merge after that :)

@randomPoison randomPoison added the waiting for author Waiting on the issue author to reply label Jan 22, 2024
@qwandor
Copy link
Collaborator Author

qwandor commented Jan 22, 2024

We can't update to embedded-hal 1.0 until the microbit crate updates to support it. I've sent nrf-rs/microbit#123 to update that, but that in turn depends on nrf-rs/nrf-hal#431 to update nrf52833-hal.

@randomPoison
Copy link
Collaborator

Ah, that's good to know! I merged #1720 and #1721 thinking that the fact that CI passed meant it didn't break anything, but I'll roll those back to avoid breaking the embedded class in the meantime!

@qwandor
Copy link
Collaborator Author

qwandor commented Jan 23, 2024

I don't think those actually broke anything, because the examples weren't using anything from embedded-hal directly but rather depending on the re-export from the HAL crate.

@qwandor qwandor marked this pull request as ready for review April 19, 2024 10:43
Copy link
Collaborator

@mgeisler mgeisler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks! I really like how you're consistently linking to the crates you mention.

@qwandor qwandor merged commit 45aa43f into main Apr 19, 2024
36 checks passed
@qwandor qwandor deleted the embedded-hal branch April 19, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting for author Waiting on the issue author to reply
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants