Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Remote Exception by IllegalStateException in MediaBrowserComp… #81

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tpn1512
Copy link

@tpn1512 tpn1512 commented Jun 10, 2020

Replace RemoteException by IllegalStateException in MediaBrowserCompat.ConnectionCallback() as it is thrown by mediaBrowser.getSessionToken()

@monkeyswarm
Copy link
Collaborator

Thanks for updating.
Is it possible to just have the method throw an IllegalStateException, rather than catch it and throw a RuntimeException?

@monkeyswarm
Copy link
Collaborator

Disregard previous, I see now it is within an overridden method

@michaelspeedcode
Copy link

The CI is failing because we are not catching RemoteException. Please can someone add this to the catches? I tried but I'm getting a 403 when I try to publish a branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants