#Centipede Revamp blob sequence reading and writing. #1583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
cl/732234304
branch
3 times, most recently
from
04e0e2f to
fc82602
Compare
More specifically: - Handle overflowing size on both read and write. - No longer exit on bad read and return an invalid blob instead - I've checked all the current call sites to make sure this would lead to the error paths after. With these changes Centipede should behave more reliably with ill-behaved targets that corrupt the shared memory buffer used by the blob sequences. PiperOrigin-RevId: 733011103
copybara-service
bot
force-pushed
the
cl/732234304
branch
from
fc82602 to
169a96b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#Centipede Revamp blob sequence reading and writing.
More specifically:
With these changes Centipede should behave more reliably with ill-behaved targets that corrupt the shared memory buffer used by the blob sequences.