Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from compress/gzip to klauspost/pgzip #1836

Closed
wants to merge 1 commit into from

Conversation

kylecarbs
Copy link

Container layers are generally quite large (>1MB). The README of klauspost/pgzip provides benchmarks that display significant improvements in decompression time over the stdlib (~2x).

Container layers are generally quite large (>1MB). The README
of `klauspost/pgzip` provides benchmarks that display significant
improvements in decompression time over the stdlib (~2x).
@emirb
Copy link

emirb commented Nov 22, 2023

@imjasonh
When testing mutate on a 600 MB image in a .tar file, I'm seeing reduction from 40 seconds to 10 seconds.
Considering that https://github.com/klauspost/pgzip is a fully gzip compatible drop in replacement for "compress/gzip".`

Can we get this merged soon (it's been 3 weeks since PR)? :)

Copy link
Collaborator

@imjasonh imjasonh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks!

cc @jonjohnsonjr

Copy link

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Keep fresh with the 'lifecycle/frozen' label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants