Skip to content

chore: Use any instead of interface{} #3584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2025

Conversation

alexandear
Copy link
Contributor

This PR replaces interface{} with any using the command gofmt -w -r 'interface{}->any' .

any is an alias for the interface{}.

Also, enable revive.use-any rule to enforce using any in the future PRs.

@alexandear alexandear marked this pull request as draft June 2, 2025 11:33
Copy link

codecov bot commented Jun 2, 2025

Codecov Report

Attention: Patch coverage is 77.27273% with 5 lines in your changes missing coverage. Please review.

Project coverage is 91.32%. Comparing base (b52ed30) to head (53ca2f9).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
test/fields/fields.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3584   +/-   ##
=======================================
  Coverage   91.32%   91.32%           
=======================================
  Files         184      184           
  Lines       16143    16143           
=======================================
  Hits        14742    14742           
  Misses       1227     1227           
  Partials      174      174           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alexandear alexandear marked this pull request as ready for review June 2, 2025 12:24
@gmlewis gmlewis changed the title chore: Use any instead of interface{} chore: Use any instead of interface{} Jun 2, 2025
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @alexandear!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@stevehipwell - might you be available for a code review? Thank you!

Copy link
Contributor

@stevehipwell stevehipwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewis
Copy link
Collaborator

gmlewis commented Jun 3, 2025

Thank you, @stevehipwell!
Merging.

@gmlewis gmlewis merged commit 3c5408e into google:master Jun 3, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants