Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uninstall without uninstall args #117

Merged
merged 3 commits into from
Aug 28, 2024
Merged

Uninstall without uninstall args #117

merged 3 commits into from
Aug 28, 2024

Conversation

sbrito85
Copy link
Collaborator

@sbrito85 sbrito85 commented Aug 9, 2024

Windows adds registry keys for uninstalls. If uninstall args are not specified, use the uninstall string from the registry. Currently targeting MSI but leaving room for other formats.

Windows adds registry keys for uninstalls. If uninstall args are not specified, use the uninstall string from the registry. Currently targeting MSI but leaving room for other formats.
Copy link
Collaborator

@nguyen-phillip nguyen-phillip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's some indentation problems that look like spaces / tabs issues. Can you run the code through gofmt?

@sbrito85
Copy link
Collaborator Author

done

@nguyen-phillip nguyen-phillip merged commit af448c8 into google:master Aug 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants