update exe uninstall to be more reliable #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nguyen-phillip
approved these changes
Sep 4, 2024
| continue | ||
| } | ||
| // Remove display name whitespace to conform to package name | ||
| if strings.ToLower(strings.ReplaceAll(displayName, " ", "")) == strings.ToLower(installSource) { | ||
| // Check if the value exists, move on if it doesn't | ||
| un, _, err := q.GetStringValue("QuietUninstallString") | ||
| if err != nil { |
There was a problem hiding this comment.
Should this be if err != nil || un == "" ?
There was a problem hiding this comment.
There's an assumption that if we hit an error hear(likely not exists), that un will be "". I have yet to see a case where silentinstallstring exists but has no value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull display name to compare with package name, remove whitespace from display name.
Fix logic to search uninstall string if silent string does not exist.