Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add googet goo and exe to git ignore and remove files #122

Merged
merged 2 commits into from
Sep 4, 2024
Merged

Add googet goo and exe to git ignore and remove files #122

merged 2 commits into from
Sep 4, 2024

Conversation

sbrito85
Copy link
Collaborator

@sbrito85 sbrito85 commented Sep 4, 2024

Prevent accidental uploads of pre-built goo and exe files

nguyen-phillip
nguyen-phillip approved these changes Sep 4, 2024
View reviewed changes
Copy link
Collaborator

@nguyen-phillip nguyen-phillip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps use wildcards with *.exe and *.goo to exclude all exe/goos (and not be dependent on the goo version)?

@sbrito85
Copy link
Collaborator Author

sbrito85 commented Sep 4, 2024

Perhaps use wildcards with *.exe and *.goo to exclude all exe/goos (and not be dependent on the goo version)?

done

@nguyen-phillip nguyen-phillip merged commit bf33c67 into google:master Sep 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nguyen-phillip nguyen-phillip nguyen-phillip approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbrito85 @nguyen-phillip