Closed
Conversation
- Will be useful for validation runner and generate default trace - Allows None values in sequence_examples
Northbadge
force-pushed
the
validation-runner-peel
branch
from
096d1fb to
468adc3
Compare
Northbadge
force-pushed
the
validation-runner-peel
branch
from
e7dff71 to
113c71e
Compare
Collaborator
|
lgtm, but rename the patch because there's no "raw_" anywhere anymore |
yundiqian
reviewed
Aug 15, 2022
| def get_rewards(result: Dict) -> List[float]: | ||
| return [v[1] for v in result.values()] | ||
|
|
||
| def collect_results( |
Contributor
There was a problem hiding this comment.
i think it is over-engineering to refactor the collect_data function with the collect_results function, the options in the collect_results here are too complicated and the return type is also confusing, the name of collect_results and collect_data is also confusing.
I recommend to just write a function for your evaluation purpose, in this way the function args and return types will be much clearer
Contributor
Author
There was a problem hiding this comment.
that's sounds reasonable. I'll just make _compile_fn public scoped, that's essentially all I need anyway
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #96
(was #98 before I messed up my branch reset and GitHub took the opportunity to close it)