Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test on Python 3.12 #439

Closed
wants to merge 2 commits into from
Closed

Test on Python 3.12 #439

wants to merge 2 commits into from

Conversation

cclauss
Copy link
Collaborator

@cclauss cclauss commented Feb 11, 2025 •
edited
Loading

What changes will be required to run on Python 3.12?

Blocked by:

@cclauss cclauss closed this Feb 11, 2025
@cclauss cclauss reopened this Feb 11, 2025
boomanaiden154
boomanaiden154 reviewed Feb 11, 2025
View reviewed changes
Copy link
Collaborator

@boomanaiden154 boomanaiden154 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lockfile needs to be regenerated when touching Pipfile.

This is also blocked on tf-agents.

@cclauss
Copy link
Collaborator Author

cclauss commented Feb 11, 2025 •
edited
Loading

Pipfile is an issue for me... #421 (comment)

Let's close for now and we can revisit this when the two dependencies are Py3.12-ready.

@cclauss cclauss closed this Feb 11, 2025
@cclauss cclauss deleted the python3.12 branch February 11, 2025 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boomanaiden154 boomanaiden154 boomanaiden154 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cclauss @boomanaiden154