Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parse action versions out of workflow files #420

Merged
merged 26 commits into from
May 25, 2023

Conversation

devoncarew
Copy link
Collaborator

@devoncarew devoncarew commented Oct 7, 2022

  • parse action versions out of workflow files when the versions in that action file are managed by dependabot

This will allow us to configure dependabot version upgrades for repos that use mono_repo to generate (and re-generate) their actions configurations.

@codecov-commenter
Copy link

codecov-commenter commented Oct 7, 2022

Codecov Report

Merging #420 (dd4300b) into master (69c4392) will increase coverage by 15.41%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           master      #420       +/-   ##
============================================
+ Coverage   84.58%   100.00%   +15.41%     
============================================
  Files          34         1       -33     
  Lines        1499         1     -1498     
============================================
- Hits         1268         1     -1267     
+ Misses        231         0      -231     

see 33 files with indirect coverage changes

@coveralls
Copy link

coveralls commented Oct 7, 2022

Pull Request Test Coverage Report for Build 5082083298

  • 45 of 46 (97.83%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.6%) to 85.183%

Changes Missing Coverage Covered Lines Changed/Added Lines %
mono_repo/lib/src/task_type.dart 1 2 50.0%
Totals Coverage Status
Change from base Build 4984445509: 0.6%
Covered Lines: 1305
Relevant Lines: 1532

💛 - Coveralls

@devoncarew devoncarew marked this pull request as ready for review October 9, 2022 15:30
@kevmoo
Copy link
Collaborator

kevmoo commented Nov 10, 2022

Are we going to run with this folks?

@devoncarew
Copy link
Collaborator Author

(triaging my PR queue)

@jakemac53
Copy link
Collaborator

Fwiw I am generally on board with this change, i think it just fell through the cracks

@devoncarew
Copy link
Collaborator Author

Reopening

@devoncarew devoncarew reopened this May 22, 2023
Copy link
Collaborator Author

@devoncarew devoncarew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some review comments addressed (1-2 or two left to do).

Copy link
Collaborator

@jakemac53 jakemac53 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can follow up with a test if you like, or you can add one and then merge

@devoncarew
Copy link
Collaborator Author

I can follow up with a test if you like

That would be much appreciated :)

@jakemac53
Copy link
Collaborator

@devoncarew can you push a pubspec/changelog update when you get a chance? I would go ahead and just release this now.

@devoncarew
Copy link
Collaborator Author

can you push a pubspec/changelog update when you get a chance? I would go ahead and just release this now.

done -

@devoncarew
Copy link
Collaborator Author

Looks like the code coverage upload is failing -

@jakemac53
Copy link
Collaborator

cc @kevmoo I believe this is just because its running from your fork which won't work, it only works for prs from a branch on the main repo. I believe we can just merge anyways.

@jakemac53 jakemac53 merged commit a1da087 into google:master May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants