-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parse action versions out of workflow files #420
Conversation
Codecov Report
@@ Coverage Diff @@
## master #420 +/- ##
============================================
+ Coverage 84.58% 100.00% +15.41%
============================================
Files 34 1 -33
Lines 1499 1 -1498
============================================
- Hits 1268 1 -1267
+ Misses 231 0 -231 |
Pull Request Test Coverage Report for Build 5082083298
💛 - Coveralls |
Are we going to run with this folks? |
(triaging my PR queue) |
Fwiw I am generally on board with this change, i think it just fell through the cracks |
Reopening |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some review comments addressed (1-2 or two left to do).
generate the internal action versions from the current ones used in this repo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can follow up with a test if you like, or you can add one and then merge
That would be much appreciated :) |
add a test that validate can pass if versions dont match but dependabot is used
@devoncarew can you push a pubspec/changelog update when you get a chance? I would go ahead and just release this now. |
done - |
Looks like the code coverage upload is failing - |
cc @kevmoo I believe this is just because its running from your fork which won't work, it only works for prs from a branch on the main repo. I believe we can just merge anyways. |
This will allow us to configure dependabot version upgrades for repos that use mono_repo to generate (and re-generate) their actions configurations.