Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore ordering of jobs to what it was before #450

Merged
merged 4 commits into from
May 15, 2023
Merged

Conversation

jakemac53
Copy link
Collaborator

The latest package:graphs changed its ordering for things where the ordering isn't specified.

This uses a secondary sort to restore the order for non-dependent stages/jobs so that they go in insertion order, which is the order in which they were listed in the configs (and also matches the old order).

@jakemac53 jakemac53 requested review from kevmoo and natebosch May 15, 2023 16:56
@github-actions
Copy link

Package publishing

Package Version Status Publish tag (post-merge)
package:mono_repo 6.5.6 ready to publish mono_repo-v6.5.6

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

@codecov-commenter
Copy link

codecov-commenter commented May 15, 2023

Codecov Report

Merging #450 (f571948) into master (19e7336) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #450      +/-   ##
==========================================
+ Coverage   84.55%   84.58%   +0.03%     
==========================================
  Files          34       34              
  Lines        1496     1499       +3     
==========================================
+ Hits         1265     1268       +3     
  Misses        231      231              
Impacted Files Coverage Δ
mono_repo/lib/src/ci_shared.dart 98.23% <100.00%> (+0.04%) ⬆️

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4983114726

  • 11 of 11 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 84.59%

Totals Coverage Status
Change from base Build 4863064433: 0.03%
Covered Lines: 1268
Relevant Lines: 1499

💛 - Coveralls

@jakemac53 jakemac53 merged commit 69c4392 into master May 15, 2023
@jakemac53 jakemac53 deleted the restore-ordering branch May 15, 2023 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants