Integrate HiGHS and few minor fixes#5139
Open
PedramHooshangiAUGAI wants to merge 7 commits intogoogle:stablefrom
Open
Integrate HiGHS and few minor fixes#5139PedramHooshangiAUGAI wants to merge 7 commits intogoogle:stablefrom
PedramHooshangiAUGAI wants to merge 7 commits intogoogle:stablefrom
Conversation
Acorn 11226 update augmenta-ai/or-tools
…lver Fix crash when HiGHS returns FEASIBLE status (time limit, node limit, gap tolerance). Now populates variable_value, objective_value, and best_objective_bound for both MPSOLVER_OPTIMAL and MPSOLVER_FEASIBLE, consistent with SCIP solver behavior.
ACORN-11869: Populate variable values for FEASIBLE status in HiGHS
- Fix floating-point rounding assertions in clock.c - Handle zero/near-zero constraint coefficients in cons_linear.c - Clamp negative solving time in stat.c instead of asserting - Update MODULE.bazel to apply SCIP patch via git_override
ACORN-11869: Add SCIP debug-build assertion fixes to patch file
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Author
|
CLA is green, no conflicts, workflow is awaiting maintainer approval. Happy to address review comments :). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds HiGHS solver support throughout the codebase, updates the HiGHS dependency, and improves integration with the build system and solver interfaces. It also includes a patch for SCIP to fix debug-build assertions and some minor documentation and logging improvements.
HiGHS Solver Integration:
ChristofidesPathSolver, including the necessary preprocessor checks and solver instantiation (ortools/graph/christofides.h). [1] [2] [3] [4]RunAllExamples(examples/cpp/uncapacitated_facility_location.cc).Build System and Configuration:
MODULE.bazeland enabled HiGHS in the workspace and Makefile (MODULE.bazel,or-tools.code-workspace,makefiles/Makefile.cpp.mk). [1] [2] [3]git_overridefor SCIP with a debug-build assertion patch inMODULE.bazeland included the patch file (MODULE.bazel,patches/scip-v10.0.0.patch). [1] [2]Solver Interface Improvements:
HighsInterfaceto correctly reference HiGHS instead of PDLP in comments and theSolverVersion()method (ortools/linear_solver/highs_interface.cc). [1] [2]HighsSolveProtoby setting the objective value for both optimal and feasible statuses (ortools/linear_solver/proto_solver/highs_proto_solver.cc).<!--Thank you for submitting a PR!
Please make sure you are targeting the main branch instead of stable and that all contributors have signed the Contributor License Agreement.
This simply gives us permission to use and redistribute your contributions as part of the project.
Head over to https://cla.developers.google.com/ to see your current agreements on file or to sign a new one.
This project follows https://opensource.google.com/conduct/
Thanks!
-->