fix: don't panic if openSSH version cannot be parsed #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikvarga
reviewed
Mar 11, 2025
| @@ -69,6 +69,16 @@ func (Detector) Requirements() *plugin.Capabilities { | |||
| // RequiredExtractors returns an empty list as there are no dependencies. | |||
| func (Detector) RequiredExtractors() []string { return []string{} } | |||
|
|
|||
| func isVersionWithinRange(openSSHVersion string, lower string, upper string) (bool, error) { | |||
| isWithinRange, err := versionLessEqual(lower, openSSHVersion) | |||
There was a problem hiding this comment.
The logic is a bit convoluted here, I wonder if it'd be cleaner to append the errors. E.g.
lessEq, err1 := versionLessEqual(...)
greaterEq, err2 := versionLessEqual(...)
return lessEq && greaterEq, errors.Join(err1, err2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branched off of #496
Addresses #496 (comment)