Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: ignored packages should be filtered out before scanning #1206

Merged
merged 5 commits into from
Aug 28, 2024

Conversation

giovanni-bozzano
Copy link
Contributor

Currently, vulnerabilities in packages that are ignored in the config file are filtered out after the scanning process.
To optimize the scanning process, these packages should be preemptively ignored.

@giovanni-bozzano giovanni-bozzano changed the title Ignored packages should be filtered out before scanning perf: ignored packages should be filtered out before scanning Aug 26, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 26, 2024

Codecov Report

Attention: Patch coverage is 63.15789% with 7 lines in your changes missing coverage. Please review.

Project coverage is 65.90%. Comparing base (edaf998) to head (f4f08a3).

Files Patch % Lines
pkg/osvscanner/osvscanner.go 63.15% 5 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1206      +/-   ##
==========================================
+ Coverage   65.87%   65.90%   +0.03%     
==========================================
  Files         168      168              
  Lines       14116    14121       +5     
==========================================
+ Hits         9299     9307       +8     
+ Misses       4301     4297       -4     
- Partials      516      517       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@another-rex another-rex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Collaborator

@G-Rath G-Rath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@another-rex another-rex merged commit 2735f9d into google:main Aug 28, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants