Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Base image dedup #1585

Merged
merged 5 commits into from
Feb 11, 2025
Merged

fix: Base image dedup #1585

merged 5 commits into from
Feb 11, 2025

Conversation

another-rex
Copy link
Collaborator

Deduplicate base images to always pick the latest layer when multiple layers returns with the same base image result.

@another-rex another-rex requested a review from hogo6002 February 7, 2025 04:28
@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.33%. Comparing base (a2811d6) to head (ac97b80).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1585      +/-   ##
==========================================
+ Coverage   69.31%   69.33%   +0.01%     
==========================================
  Files         200      200              
  Lines       19033    19042       +9     
==========================================
+ Hits        13193    13202       +9     
- Misses       5133     5134       +1     
+ Partials      707      706       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@hogo6002 hogo6002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we really need to add some tests in the future

@another-rex
Copy link
Collaborator Author

yeah, I'll actually take a look at making some JSON tests now.

@another-rex another-rex merged commit 4a16ab6 into google:main Feb 11, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants