Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix CI to use newer npm on node 14 #298

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

aabmass
Copy link
Member

@aabmass aabmass commented Aug 28, 2024

The npm version coming with Node 14 in Github Actions is v6 which does not support lockfile v3 checked into this repo:

npm WARN read-shrinkwrap This version of npm is compatible with lockfileVersion@1, but package-lock.json was generated for lockfileVersion@3. I'll try to do my best with it!

which results in non-hermetic build (see #297). This PR upgrades npm to the newest version supported in Node 14, which understands the lockfile to pull in exact dependencies.

@codecov-commenter
Copy link

codecov-commenter commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.92%. Comparing base (dead429) to head (37ddf4c).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #298   +/-   ##
=======================================
  Coverage   41.92%   41.92%           
=======================================
  Files          14       14           
  Lines        2092     2092           
  Branches       42       42           
=======================================
  Hits          877      877           
  Misses       1197     1197           
  Partials       18       18           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aabmass aabmass force-pushed the test-broken-ci branch 3 times, most recently from 6f2c47d to 9ef2e33 Compare August 28, 2024 22:27
@aabmass aabmass changed the title chore: test lint chore: fix CI to use newer npm on node 14 Aug 28, 2024
@aabmass aabmass marked this pull request as ready for review August 28, 2024 22:36
@aabmass aabmass enabled auto-merge (squash) August 29, 2024 02:28
@aabmass aabmass merged commit 980970a into google:main Aug 29, 2024
9 checks passed
@aabmass aabmass deleted the test-broken-ci branch August 29, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants