Change async fns to return Future + Send. #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antiphoton
previously approved these changes
Jun 22, 2022
Change local variables in async function to implement Send, so that they return Futures that implement Send. This is a prerequisite for serving SXGs in a request handler in hyper, without relying on something like block_on or thread::spawn which could limit concurrency.
antiphoton
approved these changes
Jul 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change local variables in async function to implement Send, so that they return
Futures that implement Send.
This is a prerequisite for serving SXGs in a request handler in hyper, without
relying on something like block_on or thread::spawn which could limit
concurrency.
Addresses #250.