-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
locust fingerprints with all dependencies added #311
base: master
Are you sure you want to change the base?
Conversation
Hi @mr-mosi, It seems like our automation did not trigger on this PR. ~tooryx |
Hi @tooryx yes sure. I will push the changes. |
@tooryx Could you remove the |
Hey @mr-mosi, It seems like the generated fingerprints are missing from the PR. Can you add them? Thank you, |
@tooryx I fixed some bugs, moved scripts to the correct directory and created the .binproto file |
Add ending newline
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @mr-mosi, thanks for your contribution!
I've left some comments on a few things that can be improved.
Please also ensure to do the following:
- Sync the fork with the main repo
- Delete the old files in
community/fingerprinters
- The binproto file is in the wrong directory, it should be in
google/fingerprinters/web/src/main/resources/fingerprinters/web/data/community/locust.binproto
(notice it'scommunity/locust.binproto
, notgoogle/locust.binproto
at the end) - Add the missing versions to the
versions.txt
file. I see that there are images available from0.12.1
up to2.33.0
. I've made sure the changes I suggested work on all these versions.
google/fingerprinters/web/scripts/updater/community/locust/app/docker-compose.yaml
Outdated
Show resolved
Hide resolved
google/fingerprinters/web/scripts/updater/community/locust/app/docker-compose.yaml
Outdated
Show resolved
Hide resolved
google/fingerprinters/web/scripts/updater/community/locust/app/docker-compose.yaml
Outdated
Show resolved
Hide resolved
google/fingerprinters/web/scripts/updater/community/locust/app/locustfile.py
Outdated
Show resolved
Hide resolved
google/fingerprinters/web/scripts/updater/community/locust/app/docker-compose.yaml
Outdated
Show resolved
Hide resolved
google/fingerprinters/web/scripts/updater/community/locust/update.sh
Outdated
Show resolved
Hide resolved
google/fingerprinters/web/scripts/updater/community/locust/update.sh
Outdated
Show resolved
Hide resolved
google/fingerprinters/web/scripts/updater/community/locust/update.sh
Outdated
Show resolved
Hide resolved
google/fingerprinters/web/scripts/updater/community/locust/update.sh
Outdated
Show resolved
Hide resolved
@savio-doyensec Hi, do you want to add versions that end containing ".dev" like this one too: https://hub.docker.com/layers/locustio/locust/2.32.4.dev25/images/sha256-66f62cc0665b93845026f9a4068a00dad674170a4d48cdc2a7d320747f37b016 ? |
I think having only the stable versions is good enough. I launched a few different versions and noticed that the interface rarely changes anyway. |
I'll update the .bintproto file soon. |
I've also added the |
Since this is not required for the updater I think it's better to remove it to keep the repository clean, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, here are a few more minor things to fix and then the plugin is good to go.
Please also remember to submit an updated binproto file with the new versions after applying the changes
google/fingerprinters/web/scripts/updater/community/locust/getAllTags.py
Outdated
Show resolved
Hide resolved
google/fingerprinters/web/scripts/updater/community/locust/update.sh
Outdated
Show resolved
Hide resolved
…se config and locustfile to comply with versions <=1.14.5
Hi @savio-doyensec Also, for versions below 1.14.5 the docker-compose and locust python file is changed too |
LGTM - Approved Reviewer: Savio, Doyensec |
Hi dear tsunami team,
I just finished getting fingerprints for Locust and put them in the desired directory.
please check it. last pull request can be ignored. thanks for your time.